spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mengxr <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-5253] [ML] LinearRegression with L1/L2 ...
Date Wed, 04 Feb 2015 01:22:37 GMT
Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4259#discussion_r24056248
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/param/sharedParams.scala ---
    @@ -23,6 +23,27 @@ private[ml] trait HasRegParam extends Params {
       def getRegParam: Double = get(regParam)
     }
     
    +private[ml] trait HasElasticNetParam extends HasRegParam {
    +  /** param for elastic net regularization parameter */
    +  val alphaParam: DoubleParam = new DoubleParam(
    --- End diff --
    
    I would move it to `LinearRegression` and rename it to `alpha`. This is not a shared param.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message