spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-5549] Define TaskContext interface in S...
Date Tue, 03 Feb 2015 06:18:25 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4324#discussion_r23984946
  
    --- Diff: core/src/test/java/test/org/apache/spark/JavaTaskCompletionListenerImpl.java
---
    @@ -15,9 +15,10 @@
      * limitations under the License.
      */
     
    -package org.apache.spark.util;
    +package test.org.apache.spark;
    --- End diff --
    
    note that I changed the package to make sure we test package visibility correctly also.

    
    We should do this for other Java API tests, but we can do those later.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message