spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From marmbrus <...@git.apache.org>
Subject [GitHub] spark pull request: [WIP][SPARK-5501][SPARK-5420][SQL] Write suppo...
Date Mon, 02 Feb 2015 20:51:14 GMT
Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4294#discussion_r23957260
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
    @@ -334,6 +335,71 @@ class SQLContext(@transient val sparkContext: SparkContext)
         applySchema(rowRDD, appliedSchema)
       }
     
    +  @Experimental
    +  def load(
    +    dataSourceName: String,
    +    options: Map[String, String]): DataFrame = {
    --- End diff --
    
    No we don't but I think there is any reason to force the syntactic overhead of saying
`Map(...)` on the user.  If they put double keys in a `Map` they will also be silently discarded
so I don't think we are regressing at all.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message