spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From OopsOutOfMemory <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-5264][SQL] Support `drop temporary tabl...
Date Mon, 02 Feb 2015 15:43:16 GMT
Github user OopsOutOfMemory commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4060#discussion_r23932366
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/ddl.scala ---
    @@ -231,6 +241,32 @@ private [sql] case class CreateTempTableUsing(
       }
     }
     
    +private[sql] case class DropTable(
    +    tableName: String,
    +    isExists: Boolean,
    +    temporary: Boolean) extends Command
    --- End diff --
    
    @liancheng Thanks for the code review, most of the them are very valueable for me. 
    And also I tried your suggestions, but it's not easy to cover both `sql` and `hivesql`
dialect test code. And I think to use a logical node and use each dialect's own strategy to
convert will more reasonable and easy to understand.  Sorry if I'm wrong.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message