Return-Path: X-Original-To: apmail-spark-reviews-archive@minotaur.apache.org Delivered-To: apmail-spark-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 341B5C039 for ; Mon, 26 Jan 2015 06:22:34 +0000 (UTC) Received: (qmail 45178 invoked by uid 500); 26 Jan 2015 06:22:34 -0000 Delivered-To: apmail-spark-reviews-archive@spark.apache.org Received: (qmail 45153 invoked by uid 500); 26 Jan 2015 06:22:34 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 45142 invoked by uid 99); 26 Jan 2015 06:22:34 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Jan 2015 06:22:34 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id CF1FEE04BF; Mon, 26 Jan 2015 06:22:33 +0000 (UTC) From: mengxr To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark pull request: [SPARK-5384][mllib] Vectors.sqdist returns inc... Content-Type: text/plain Message-Id: <20150126062233.CF1FEE04BF@git1-us-west.apache.org> Date: Mon, 26 Jan 2015 06:22:33 +0000 (UTC) Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/4183#issuecomment-71418817 LGTM. Merged into master. For the performance issue, let's open another PR for it. I can see at least the condition "v1.indices.length / v1.size < 0.5" is wrong, because the left-hand side returns an integer. Please let me know whether you want to continue working on this. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org