Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: mengxr <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-4109-spark@git.apache.org>
In-Reply-To: <git-pr-4109-spark@git.apache.org>
Subject: [GitHub] spark pull request: [SPARK-5321] Support for transposing
 local mat...
Content-Type: text/plain
Message-Id: <20150120235853.DAC0DE03E3@git1-us-west.apache.org>
Date: Tue, 20 Jan 2015 23:58:53 +0000 (UTC)

Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4109#discussion_r23268088
  
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala ---
    @@ -114,21 +106,47 @@ class DenseMatrix(val numRows: Int, val numCols: Int, val values: Array[Double])
       require(values.length == numRows * numCols, "The number of values supplied doesn't match the " +
         s"size of the matrix! values.length: ${values.length}, numRows * numCols: ${numRows * numCols}")
     
    -  override def toArray: Array[Double] = values
    +  override def toArray: Array[Double] = {
    +    if (!isTransposed) {
    +      values
    +    } else {
    +      val transposedValues = new Array[Double](values.length)
    +      var j = 0
    +      while (j < numCols) {
    +        var i = 0
    +        val indStart = j * numRows
    +        while (i < numRows) {
    +          transposedValues(indStart + i) = values(j + i * numCols)
    +          i += 1
    +        }
    +        j += 1
    +      }
    +      transposedValues
    +    }
    +  }
     
       override def equals(o: Any) = o match {
         case m: DenseMatrix =>
    -      m.numRows == numRows && m.numCols == numCols && Arrays.equals(toArray, m.toArray)
    +      m.numRows == numRows && m.numCols == numCols && jArrays.equals(toArray, m.toArray)
         case _ => false
       }
     
    -  private[mllib] def toBreeze: BM[Double] = new BDM[Double](numRows, numCols, values)
    +  private[mllib] def toBreeze: BM[Double] = {
    --- End diff --
    
    Do we handle the transpose flag in `fromBreeze`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org