Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: rxin <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-4115-spark@git.apache.org>
In-Reply-To: <git-pr-4115-spark@git.apache.org>
Subject: [GitHub] spark pull request: [SPARK-5323][SQL] Remove Row's Seq
 inheritance...
Content-Type: text/plain
Message-Id: <20150120174902.8E5E1E0396@git1-us-west.apache.org>
Date: Tue, 20 Jan 2015 17:49:02 +0000 (UTC)

Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4115#discussion_r23240121
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/parquet/ParquetConverter.scala ---
    @@ -66,7 +66,7 @@ private[sql] object CatalystConverter {
     
       // TODO: consider using Array[T] for arrays to avoid boxing of primitive types
       type ArrayScalaType[T] = Seq[T]
    -  type StructScalaType[T] = Seq[T]
    +  type StructScalaType[T] = Row
    --- End diff --
    
    Row used to be a Seq so why not?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org