Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: andrewor14 <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-3783-spark@git.apache.org>
In-Reply-To: <git-pr-3783-spark@git.apache.org>
Subject: [GitHub] spark pull request: [SPARK-4951][Core] Fix the issue that a
 busy e...
Content-Type: text/plain
Message-Id: <20150107224202.04F0A9D2CC3@tyr.zones.apache.org>
Date: Wed,  7 Jan 2015 22:42:01 +0000 (UTC)

Github user andrewor14 commented on the pull request:

    https://github.com/apache/spark/pull/3783#issuecomment-69106025
  
    Hey @zsxwing thanks for fixing these. I believe points 3, 4, 5 are covered sufficiently in this PR. I still don't fully understanding (1). What is the race condition there, and which part of your patch fixes that? As for (2), I left an inline comment explaining why the original code is written as such, and why the corresponding change in this PR overlooks another issue.
    
    By the way, in the future it would be good to break this down into multiple issues and patches. It seems to me that only (2) actually corresponds to SPARK-4951. Let me know if this is not the case.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org