spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GenTang <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-4983]exception handling about adding ta...
Date Sat, 31 Jan 2015 18:06:56 GMT
Github user GenTang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3986#discussion_r23890734
  
    --- Diff: ec2/spark_ec2.py ---
    @@ -569,6 +569,8 @@ def launch_cluster(conn, opts, cluster_name):
             master_nodes = master_res.instances
             print "Launched master in %s, regid = %s" % (zone, master_res.id)
     
    +    # Wait for the information of the just-launched instances to be propagated within
AWS
    +    time.sleep(5)
    --- End diff --
    
    @nchammas 
    Maybe we should insert a print here to tell the client that we are waiting for the information
to be propagated, since there will be 5 seconds idle between `launch master in` and `wait
for the cluster to enter`. 
    How do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message