spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-5500. Document that feeding hadoopFile i...
Date Sat, 31 Jan 2015 02:59:17 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4293#discussion_r23885815
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/HadoopRDD.scala ---
    @@ -308,6 +309,14 @@ class HadoopRDD[K, V](
         // Do nothing. Hadoop RDD should not be checkpointed.
       }
     
    +  override def persist(storageLevel: StorageLevel): this.type = {
    +    if (storageLevel.deserialized) {
    +      throw new SparkException("Can't cache HadoopRDDs as deserialized objects because
Hadoop's" +
    --- End diff --
    
    throwing an exception is a bit extreme and will break existing code. How about just a
warning?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message