spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lianhuiwang <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-5173]support python application running...
Date Sat, 31 Jan 2015 02:29:14 GMT
Github user lianhuiwang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3976#discussion_r23885537
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
    @@ -172,7 +172,8 @@ private[spark] class SparkSubmitArguments(args: Seq[String], env:
Map[String, St
         }
     
         // Require all python files to be local, so we can add them to the PYTHONPATH
    -    if (isPython) {
    +    // when yarn-cluster, all python files can be non-local
    +    if (isPython && !master.equalsIgnoreCase("yarn-cluster")) {
    --- End diff --
    
    how about i move checkRequired here to SparkSubmit, because SparkSubmit can get isYarnClusterMode.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message