spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tdas <...@git.apache.org>
Subject [GitHub] spark pull request: [STREAMING] SPARK-4986 Wait for receivers to d...
Date Wed, 28 Jan 2015 17:53:38 GMT
Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3868#discussion_r23706669
  
    --- Diff: streaming/src/main/scala/org/apache/spark/streaming/scheduler/ReceiverTracker.scala
---
    @@ -208,6 +208,7 @@ class ReceiverTracker(ssc: StreamingContext, skipReceiverLaunch: Boolean
= false
       /** This thread class runs all the receivers on the cluster.  */
       class ReceiverLauncher {
         @transient val env = ssc.env
    +    private var terminated = true
    --- End diff --
    
    Why is this initialized to true? Should it not be initialized to false. Then line 300
is not necessary. 
    Also since this var is being modified and checked from multiple threads, best to mark
this as volatile. And also transient. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message