spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From catap <...@git.apache.org>
Subject [GitHub] spark pull request: Don't return `ERROR 500` when have missing arg...
Date Wed, 28 Jan 2015 16:50:01 GMT
Github user catap commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4239#discussion_r23701196
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/JobPage.scala ---
    @@ -32,7 +32,12 @@ private[ui] class JobPage(parent: JobsTab) extends WebUIPage("job")
{
     
       def render(request: HttpServletRequest): Seq[Node] = {
         listener.synchronized {
    -      val jobId = request.getParameter("id").toInt
    +      val paramaterId = request.getParameter("id")
    +      if (paramaterId.equals("")) {
    --- End diff --
    
    Yes, I updated the code to handle both cases.
    
    BTW I test it only by hand because I not found any testcase for HTTP UI. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message