spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JoshRosen <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-5154] [PySpark] [Streaming] Kafka strea...
Date Wed, 28 Jan 2015 02:06:30 GMT
Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3715#discussion_r23661073
  
    --- Diff: core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala ---
    @@ -374,49 +375,63 @@ private[spark] object PythonRDD extends Logging {
         // The right way to implement this would be to use TypeTags to get the full
         // type of T.  Since I don't want to introduce breaking changes throughout the
         // entire Spark API, I have to use this hacky approach:
    +    def write(bytes: Array[Byte]) {
    --- End diff --
    
    And similarly, maybe call this writeBytes?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message