spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-3562]Periodic cleanup event logs
Date Tue, 27 Jan 2015 23:23:58 GMT
Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4214#discussion_r23653061
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala
---
    @@ -163,9 +179,6 @@ private[history] class FsHistoryProvider(conf: SparkConf) extends
ApplicationHis
        * applications that haven't been updated since last time the logs were checked.
        */
       private[history] def checkForLogs(): Unit = {
    -    lastLogCheckTimeMs = getMonotonicTimeMs()
    -    logDebug("Checking for logs. Time is now %d.".format(lastLogCheckTimeMs))
    --- End diff --
    
    Good point. The tests don't expect anything to be happening in the background, instead
they rely on being able to trigger these updates explicitly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message