spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ksakellis <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-5393. Flood of util.RackResolver log mes...
Date Tue, 27 Jan 2015 18:21:17 GMT
Github user ksakellis commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4192#discussion_r23629409
  
    --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala ---
    @@ -60,6 +62,9 @@ private[yarn] class YarnAllocator(
     
       import YarnAllocator._
     
    +  // RackResolver logs an INFO message whenever it resolves a rack, which is way too
often.
    +  Logger.getLogger(classOf[RackResolver]).setLevel(Level.WARN)
    --- End diff --
    
    Well, I disagree. A user will get very frustrated if they are debugging an issue and they
can't turn on the logging. Can you add a check: Logger.getLogger(classOf[RackResolver]).getLevel()
!= null at least you won't be overriding the logging level if it is set.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message