spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-4508] [SQL] build native date type to c...
Date Tue, 27 Jan 2015 18:11:28 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3732#discussion_r23628599
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/Row.scala ---
    @@ -252,7 +252,7 @@ trait Row extends Serializable {
        *
        * @throws ClassCastException when data type does not match.
        */
    -  def getDate(i: Int): java.sql.Date = apply(i).asInstanceOf[java.sql.Date]
    +  def getDate(i: Int): java.sql.Date = DateUtils.toJavaDate(getInt(i))
    --- End diff --
    
    one thing - you probably want to do the conversion when we create the row, like what we
do for other types, instead of doing the conversion when it is accessed. otherwise apply(i:
Int) will return date.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message