spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lianhuiwang <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-4136. Under dynamic allocation, cancel o...
Date Sun, 25 Jan 2015 05:43:02 GMT
Github user lianhuiwang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4168#discussion_r23502091
  
    --- Diff: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
    @@ -226,8 +243,11 @@ private[spark] class ExecutorAllocationManager(
        * If the cap on the number of executors is reached, give up and reset the
        * number of executors to add next round instead of continuing to double it.
        * Return the number actually requested.
    +   *
    +   * @param maxNumNeededExecutors the maximum number of executors all currently running
or pending
    +   *                              tasks could fill
        */
    -  private def addExecutors(): Int = synchronized {
    +  private def addExecutors(maxNumNeededExecutors: Int): Int = synchronized {
         // Do not request more executors if we have already reached the upper bound
         val numExistingExecutors = executorIds.size + numExecutorsPending
    --- End diff --
    
    i think there we should make  numExistingExecutors  exclude executorsPendingToRemove.size?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message