spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-5259][CORE]Make sure mapStage.pendingta...
Date Fri, 23 Jan 2015 08:53:45 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4055#discussion_r23437961
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/Task.scala ---
    @@ -106,7 +106,22 @@ private[spark] abstract class Task[T](val stageId: Int, var partitionId:
Int) ex
         if (interruptThread && taskThread != null) {
           taskThread.interrupt()
         }
    -  }  
    +  }
    +
    +  override def hashCode(): Int = {
    +    val state = Seq(stageId, partitionId)
    +    state.map(_.hashCode()).foldLeft(0)((a, b) => 31 * a + b)
    --- End diff --
    
    Maybe a better way is `(stageId + partitionId) * (stageId + partitionId + 1) / 2 +  partitionId`.
    See http://en.wikipedia.org/wiki/Pairing_function#Cantor_pairing_function


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message