spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-3541][MLLIB] New ALS implementation wit...
Date Thu, 22 Jan 2015 16:50:23 GMT
Github user srowen commented on the pull request:

    https://github.com/apache/spark/pull/3720#issuecomment-71053076
  
    @mengxr Given how familiar you are with this implementation, and the tests, I can only
be pretty sure it works. I didn't see any style issues, and thought through some of the loops
for speed/correctness but every spot check was fine. It is looking good to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message