spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From marmbrus <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-5009] [SQL] Long keyword support in SQL...
Date Wed, 21 Jan 2015 21:05:23 GMT
Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3926#discussion_r23334238
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/AbstractSparkSQLParser.scala
---
    @@ -25,15 +25,42 @@ import scala.util.parsing.input.CharArrayReader.EofCh
     
     import org.apache.spark.sql.catalyst.plans.logical._
     
    +private[sql] object KeywordNormalizer {
    --- End diff --
    
    This is kind of a nit, but since this is only used in AbstractSparkSQLParser and its subclasses
I'd just make it a protected method to avoid the syntatic overhead of a whole separate object.
 I believe you are doing further refactoring so maybe that can be done in a followup.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message