spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <>
Subject [GitHub] spark pull request: [SPARK-5311][core] Corrected EventLoggingListe...
Date Tue, 20 Jan 2015 18:20:48 GMT
Github user vanzin commented on a diff in the pull request:
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala ---
    @@ -86,8 +86,14 @@ private[spark] class EventLoggingListener(
        * Creates the log file in the configured log directory.
       def start() {
    -    if (!fileSystem.isDirectory(new Path(logBaseDir))) {
    -      throw new IllegalArgumentException(s"Log directory $logBaseDir does not exist.")
    +    try{
    --- End diff --
    nit: you needs spaces after `{` and `(` in all your code.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message