spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mengxr <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-3218, SPARK-3219, SPARK-3261, SPARK-342...
Date Tue, 20 Jan 2015 01:02:39 GMT
Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2634#discussion_r23197318
  
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/package.scala ---
    @@ -0,0 +1,145 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.mllib
    +
    +import breeze.linalg.{ Vector => BV }
    +
    +import org.apache.spark.mllib.linalg.Vector
    +import org.apache.spark.rdd.RDD
    +
    +package object base {
    --- End diff --
    
    > 1) modifications to BLAS to support arbitrary functions and axpy on SparseVectors
    
    We already support axpy on SparseVectors in `mllib.linalg.BLAS`. What do you mean by `arbitrary
functions`? If the target is to improve k-means, we only need to implement BLAS ops required
by k-means.
    
    > 2) definition of PointOps trait and various implementations for different divergences
    > 3) rewrite of clusterer to use PointOps trait but only using the squared Euclidean
distance implementation
    > 4) generalization of clustering interface to select different divergences.
    
    Sounds good.
    
    > 5) store seeds
    
    This is already covered in https://github.com/apache/spark/pull/3610, which is almost
ready to merge.
    
    > 6) maintain exactly K clusters by splitting clusters heuristicly.
    
    We had an example in `StreamingKMeans`. But if we want to support different distances,
we need to consider how to keep the new centers inside the domain.
    
    Thanks for improving your implementation! Before we merge features one by one, it would
be nice to maintain your implementation as a 3rd-party Spark package (spark-packages.org).
That helps people find it and send feedbacks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message