spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jkbradley <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-1405] [mllib] Latent Dirichlet Allocati...
Date Mon, 19 Jan 2015 18:50:11 GMT
Github user jkbradley commented on the pull request:

    https://github.com/apache/spark/pull/4047#issuecomment-70541856
  
    @EntilZha  Thanks for taking a look!  W.r.t. the class names, I really hope we can keep
a single LDA class and have an optimizer parameter which lets users specify the optimization/inference
method.  We are trying to move away from the AlgWithOptimizer naming conventions.  That will
end up affecting the abstractions you were discussing too (though maybe those abstractions
will exist but be private/protected).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message