spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pwendell <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-4923][REPL] Add Developer API to REPL t...
Date Fri, 16 Jan 2015 02:00:51 GMT
Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4034#discussion_r23059280
  
    --- Diff: repl/scala-2.10/src/main/scala/org/apache/spark/repl/SparkCommandLine.scala
---
    @@ -23,10 +23,15 @@ import scala.Predef._
     /**
      * Command class enabling Spark-specific command line options (provided by
      * <i>org.apache.spark.repl.SparkRunnerSettings</i>).
    + *
    + * @example new SparkCommandLine(Nil).settings
    + *
    + * @param args The list of command line arguments
    + * @param settings The underlying settings to associate with this set of
    + *                 command-line options
      */
     class SparkCommandLine(args: List[String], override val settings: Settings)
    --- End diff --
    
    Usually out of abundance of caution we mark it on the class level as well, even if everything
bytecode-exposed inside of the class is also marked. We tend to err on the side of over communication
with this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message