spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dbtsai <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-2309][MLlib] Multinomial Logistic Regre...
Date Wed, 14 Jan 2015 20:01:18 GMT
Github user dbtsai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3833#discussion_r22965406
  
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala
---
    @@ -61,20 +67,70 @@ class LogisticRegressionModel (
     
       override protected def predictPoint(dataMatrix: Vector, weightMatrix: Vector,
    --- End diff --
    
    I thought about having weights as a matrix, but it's required to change so many places.
For example, the gradient object has to change, the underline `GeneralizedLinearAlgorithm`
has to change as well. I'm thinking to have more clear APIs when we move the code to `ml`
package since we can do it from scratch. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message