spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nchammas <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-5188][BUILD] make-distribution.sh shoul...
Date Sat, 10 Jan 2015 03:27:13 GMT
Github user nchammas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3988#discussion_r22755950
  
    --- Diff: build/mvn ---
    @@ -48,11 +48,11 @@ install_app() {
         # check if we already have the tarball
         # check if we have curl installed
         # download application
    -    [ ! -f "${local_tarball}" ] && [ -n "`which curl 2>/dev/null`" ] &&
\
    +    [ ! -f "${local_tarball}" ] && [ -n "`type curl 2>/dev/null`" ] &&
\
    --- End diff --
    
    FWIW, the approach recommended in [this answer](http://stackoverflow.com/a/677212/877069),
which I agree with, is to use `command -v`, though honestly one way or the other it doesn't
seem like a big deal.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message