spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shivaram <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-5122] Remove Shark from spark-ec2
Date Thu, 08 Jan 2015 05:30:45 GMT
Github user shivaram commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3939#discussion_r22636258
  
    --- Diff: ec2/spark_ec2.py ---
    @@ -983,6 +969,12 @@ def real_main():
         (opts, action, cluster_name) = parse_args()
     
         # Input parameter validation
    +    if "." in opts.spark_version:
    --- End diff --
    
    Minor comment: Since we do this spark_version.replace("v", "") in two places it might
make sense to keep the old function but name it as `get_spark_version` (or `check_get_spark_version`).
You can then call it once here and once while constructing the template variables


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message