spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-5126][Core] Check the url before sendin...
Date Thu, 08 Jan 2015 01:45:16 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3927#discussion_r22630930
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala ---
    @@ -842,10 +842,34 @@ private[spark] class Master(
       }
     }
     
    +object SparkUrl {
    +
    +  def unapply(sparkUrl: String): Option[(String, Int)] = {
    --- End diff --
    
    can you add some comment explaining what valid spark url is?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message