spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From OopsOutOfMemory <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-4574][SQL] Adding support for defining ...
Date Tue, 06 Jan 2015 14:56:41 GMT
Github user OopsOutOfMemory commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3431#discussion_r22526157
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/ddl.scala ---
    @@ -83,10 +99,104 @@ private[sql] class DDLParser extends StandardTokenParsers with PackratParsers
wi
       protected lazy val className: Parser[String] = repsep(ident, ".") ^^ { case s =>
s.mkString(".")}
     
       protected lazy val pair: Parser[(String, String)] = ident ~ stringLit ^^ { case k ~
v => (k,v) }
    +
    +  protected lazy val column: Parser[StructField] =
    +  ( ident ~  ident ^^ { case name ~ typ =>
    +      StructField(name, metastoreTypes.toDataType(typ))
    --- End diff --
    
    In order to handle also possible user definition, here we can make the type forced be
lower case so __ toDataType__ can handle it correctly. Like:
    ```
    StructField(name, metastoreTypes.toDataType(typ.toLowerCase)
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message