spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tdas <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-4964] [Streaming] Exactly-once semantic...
Date Mon, 05 Jan 2015 23:42:36 GMT
Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3798#discussion_r22498831
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
    @@ -788,6 +788,20 @@ abstract class RDD[T: ClassTag](
       }
     
       /**
    +   * Applies a function to each partition of this RDD, while tracking the index
    +   * of the original partition.
    +   */
    +  def foreachPartitionWithIndex(
    --- End diff --
    
    No no, I am not suggesting anything. I am just narrowing the scope the PR by eliminating
anything that is not immediately needed in this PR (basic Kafka functionality). There is already
a lot more code necessary for this to be viable completely alternative (Driver fault-tolerance,
etc.) and it would be good to focus on only that in this PR. The `foreachPartitionWithIndex`
seems like something that can be done later independently in a different PR. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message