Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: liancheng <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-3395-spark@git.apache.org>
In-Reply-To: <git-pr-3395-spark@git.apache.org>
Subject: [GitHub] spark pull request: [SPARK-4527][SQl]Add
 BroadcastNestedLoopJoin o...
Content-Type: text/plain
Message-Id: <20141212030809.3DF67A27E76@tyr.zones.apache.org>
Date: Fri, 12 Dec 2014 03:08:09 +0000 (UTC)

Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3395#discussion_r21726677
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ---
    @@ -80,8 +80,11 @@ class JoinSuite extends QueryTest with BeforeAndAfterEach {
             classOf[HashOuterJoin]),
           ("SELECT * FROM testData right join testData2 ON key = a and key = 2",
             classOf[HashOuterJoin]),
    -      ("SELECT * FROM testData full outer join testData2 ON key = a", classOf[HashOuterJoin])
    -      // TODO add BroadcastNestedLoopJoin
    +      ("SELECT * FROM testData full outer join testData2 ON key = a", classOf[HashOuterJoin]),
    +      ("SELECT * FROM testData left JOIN testData2 ON (key*a != key+a)", classOf[BroadcastNestedLoopJoin]),
    +      ("SELECT * FROM testData right JOIN testData2 ON (key*a != key+a)", classOf[BroadcastNestedLoopJoin]),
    +      ("SELECT * FROM testData full JOIN testData2 ON (key*a != key+a)", classOf[BroadcastNestedLoopJoin])
    --- End diff --
    
    100 columns exceeded.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org