spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From james64 <...@git.apache.org>
Subject [GitHub] spark pull request: [Spark-4995] Replace Vector.toBreeze.activeIte...
Date Tue, 30 Dec 2014 13:52:11 GMT
GitHub user james64 opened a pull request:

    https://github.com/apache/spark/pull/3846

    [Spark-4995] Replace Vector.toBreeze.activeIterator with foreachActive

    New foreachActive method of vector was introduced by SPARK-4431 as more efficient alternative
to vector.toBreeze.activeIterator. There are some parts of codebase where it was not yet replaced.
    
    @dbtsai


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/james64/spark SPARK-4995-foreachActive

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/3846.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3846
    
----
commit 90a7d982e298863d16455108208fdb0765fe2ec6
Author: Jakub Dubovsky <dubovsky@avast.com>
Date:   2014-12-30T13:00:23Z

    activeIterator removed in MLUtils.saveAsLibSVMFile

commit 47a477779c2e13a4828ce633b3080e2ff7a92f6a
Author: Jakub Dubovsky <dubovsky@avast.com>
Date:   2014-12-30T13:22:29Z

    activeIterator removed in RowMatrix.toBreeze

commit 32fe6c67e46837f6625ad8ed5ed5eee20c3793d2
Author: Jakub Dubovsky <dubovsky@avast.com>
Date:   2014-12-30T13:29:35Z

    activeIterator removed - IndexedRowMatrix.toBreeze

commit 3eb7e3711fcae74031a94708233db0d8da348ea4
Author: Jakub Dubovsky <dubovsky@avast.com>
Date:   2014-12-30T13:35:17Z

    Scalastyle fix

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message