spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JoshRosen <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-4961] [CORE] Put HadoopRDD.getPartition...
Date Tue, 30 Dec 2014 18:13:59 GMT
Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3794#discussion_r22357607
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
    @@ -202,9 +202,6 @@ abstract class RDD[T: ClassTag](
        */
       final def partitions: Array[Partition] = {
         checkpointRDD.map(_.partitions).getOrElse {
    -      if (partitions_ == null) {
    --- End diff --
    
    Won't this now throw a NPE if we call `partitions` from a worker, since now this will
return `null` after the RDD is serialized and deserialized?  I guess maybe we never do that?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message