spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From OopsOutOfMemory <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-4990][Deploy]to find default properties...
Date Tue, 30 Dec 2014 02:51:34 GMT
Github user OopsOutOfMemory commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3823#discussion_r22337458
  
    --- Diff: bin/spark-submit ---
    @@ -42,7 +42,10 @@ while (($#)); do
       shift
     done
     
    -DEFAULT_PROPERTIES_FILE="$SPARK_HOME/conf/spark-defaults.conf"
    +if [ ! -d "$SPARK_CONF_DIR" ]; then
    +  SPARK_CONF_DIR="$SPARK_HOME/conf"
    --- End diff --
    
    I recommend to add `export` keyword to make the SPARK_CONF_DIR global :)
    ```
     export SPARK_CONF_DIR="$SPARK_HOME/conf"
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message