spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From liyezhang556520 <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-4989][CORE] avoid wrong eventlog conf c...
Date Tue, 30 Dec 2014 01:36:37 GMT
Github user liyezhang556520 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3824#discussion_r22336254
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala ---
    @@ -719,26 +719,28 @@ private[spark] class Master(
       def rebuildSparkUI(app: ApplicationInfo): Boolean = {
         val appName = app.desc.name
         val notFoundBasePath = HistoryServer.UI_PATH_PREFIX + "/not-found"
    -    val eventLogFile = app.desc.eventLogDir
    -      .map { dir => EventLoggingListener.getLogPath(dir, app.id) }
    -      .getOrElse {
    -        // Event logging is not enabled for this application
    -        app.desc.appUiUrl = notFoundBasePath
    -        return false
    -    }
    -    val fs = Utils.getHadoopFileSystem(eventLogFile, hadoopConf)
    +    var eventLogFile: String = null
    --- End diff --
    
    Hi @JoshRosen , `eventLogFile` is also used in `catch` block in this file.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message