spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-4567. Make SparkJobInfo and SparkStageIn...
Date Sat, 27 Dec 2014 10:09:47 GMT
Github user srowen commented on the pull request:

    https://github.com/apache/spark/pull/3426#issuecomment-68174427
  
    The mapping from class structure to serialVersionUID is well defined. The mapping from
source to class structure may not be 100% since the compiler can stick in synthetics and such.

    
    That said adding serialVersionUID is the less conservative default. The failure mode of
forgetting to detect and update serialized form changes is potentially silent corruption of
data. The failure mode of not adding it is getting exceptions about incompatible changes when
the two versions could be made compatible.
    
    I advise doing this only if really necessary because it doesn't work otherwise. It is
not something to add just because .


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message