spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request: [Minor] Fix a typo of type parameter in JavaUt...
Date Wed, 24 Dec 2014 08:49:03 GMT
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3789#discussion_r22249340
  
    --- Diff: core/src/main/scala/org/apache/spark/api/java/JavaUtils.scala ---
    @@ -80,7 +80,7 @@ private[spark] object JavaUtils {
               prev match {
                 case Some(k) =>
                   underlying match {
    -                case mm: mutable.Map[a, _] =>
    +                case mm: mutable.Map[_, _] =>
    --- End diff --
    
    Should this really be `A` to express the relation to the generic bound? although `underlying`
must already have keys of type `A` already. It just looks like that was the intent.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message