spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JoshRosen <>
Subject [GitHub] spark pull request: [SPARK-4195][Core]retry to fetch blocks's resu...
Date Wed, 24 Dec 2014 02:54:00 GMT
Github user JoshRosen commented on a diff in the pull request:
    --- Diff: core/src/main/scala/org/apache/spark/network/nio/NioBlockTransferService.scala
    @@ -96,6 +102,11 @@ final class NioBlockTransferService(conf: SparkConf, securityManager:
         future.onSuccess { case message =>
           val bufferMessage = message.asInstanceOf[BufferMessage]
           val blockMessageArray = BlockMessageArray.fromBufferMessage(bufferMessage)
    +      blockFailedCounts.synchronized {
    +        if(blockFailedCounts.contains(blockIds)){
    --- End diff --
    I think that `remove` / `-=` is idempotent, so you don't need this `contains` check.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message