spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jerryshao <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-4537][Streaming] Expand StreamingSource...
Date Wed, 24 Dec 2014 02:05:22 GMT
Github user jerryshao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3466#discussion_r22244053
  
    --- Diff: streaming/src/main/scala/org/apache/spark/streaming/StreamingSource.scala ---
    @@ -28,46 +28,58 @@ private[streaming] class StreamingSource(ssc: StreamingContext) extends
Source {
     
       private val streamingListener = ssc.progressListener
     
    -  private def registerGauge[T](name: String, f: StreamingJobProgressListener => T,
    +  private def registerGauge[T](name: String, f: StreamingJobProgressListener => Option[T],
           defaultValue: T) {
         metricRegistry.register(MetricRegistry.name("streaming", name), new Gauge[T] {
    -      override def getValue: T = Option(f(streamingListener)).getOrElse(defaultValue)
    --- End diff --
    
    OK, I will revert it back and try a better way.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message