spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From scwf <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-4935][SQL] When hive.cli.print.header c...
Date Wed, 24 Dec 2014 01:04:36 GMT
Github user scwf commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3761#discussion_r22242966
  
    --- Diff: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala
---
    @@ -278,7 +278,6 @@ private[hive] class SparkSQLCLIDriver extends CliDriver with Logging
{
     
               ret = rc.getResponseCode
               if (ret != 0) {
    -            console.printError(rc.getErrorMessage())
    --- End diff --
    
    Actually before this PR  this line do not executed, seems it does not matter, can you
explain why it will silent some error messages.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message