spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From liancheng <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-4692] [SQL] Support ! boolean logic ope...
Date Mon, 22 Dec 2014 05:59:21 GMT
Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3555#discussion_r22155207
  
    --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
---
    @@ -56,6 +56,14 @@ class HiveQuerySuite extends HiveComparisonTest with BeforeAndAfter
{
         Locale.setDefault(originalLocale)
       }
     
    +  createQueryTest("! operator",
    +    """
    +      |SELECT a FROM (
    +      |  SELECT 1 AS a FROM src LIMIT 1 UNION ALL
    +      |  SELECT 2 AS a FROM src LIMIT 1) table
    +      |WHERE !(a>1)
    +    """.stripMargin)
    --- End diff --
    
    Could you please add spaces around `>`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message