spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From liancheng <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-][Build] Cleans lib_managed before comp...
Date Sun, 21 Dec 2014 16:32:05 GMT
Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3756#discussion_r22148596
  
    --- Diff: dev/run-tests ---
    @@ -141,20 +141,22 @@ CURRENT_BLOCK=$BLOCK_BUILD
     {
     
       # NOTE: echo "q" is needed because sbt on encountering a build file with failure
    -  #+ (either resolution or compilation) prompts the user for input either q, r, etc
    -  #+ to quit or retry. This echo is there to make it not block.
    +  # (either resolution or compilation) prompts the user for input either q, r, etc
    +  # to quit or retry. This echo is there to make it not block.
       # NOTE: Do not quote $BUILD_MVN_PROFILE_ARGS or else it will be interpreted as a
    -  #+ single argument!
    +  # single argument!
       # QUESTION: Why doesn't 'yes "q"' work?
       # QUESTION: Why doesn't 'grep -v -e "^\[info\] Resolving"' work?
    -  # First build with 0.12 to ensure patches do not break the hive 12 build
    +  # First build with Hive 0.12.0 to ensure patches do not break the Hive 0.12.0 build
       HIVE_12_BUILD_ARGS="$SBT_MAVEN_PROFILES_ARGS -Phive -Phive-thriftserver -Phive-0.12.0"
    -  echo "[info] Compile with hive 0.12"
    +  echo "[info] Compile with Hive 0.12.0"
       echo -e "q\n" \
         | sbt/sbt $HIVE_12_BUILD_ARGS clean hive/compile hive-thriftserver/compile \
         | grep -v -e "info.*Resolving" -e "warn.*Merging" -e "info.*Including"
     
    -  # Then build with default version(0.13.1) because tests are based on this version
    +  # Then build with default Hive version (0.13.1) because tests are based on this version
    +  echo "[info] Compile with Hive 0.13.1"
    --- End diff --
    
    Added this line to clearly indicate the following build is against Hive 0.13.1.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message