spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From holdenk <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-4877] Allow user first classes to exten...
Date Fri, 19 Dec 2014 20:01:43 GMT
Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3725#discussion_r22125536
  
    --- Diff: core/src/main/scala/org/apache/spark/executor/ExecutorURLClassLoader.scala ---
    @@ -39,7 +39,17 @@ private[spark] class ChildExecutorURLClassLoader(urls: Array[URL],
parent: Class
           super.addURL(url)
         }
         override def findClass(name: String): Class[_] = {
    -      super.findClass(name)
    +      val loaded = super.findLoadedClass(name)
    +      if (loaded != null) {
    +        return loaded
    --- End diff --
    
    Interesting, thanks for fixing this :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message