spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-2261] Make event logger use a single fi...
Date Thu, 18 Dec 2014 21:37:05 GMT
Github user andrewor14 commented on the pull request:

    https://github.com/apache/spark/pull/1222#issuecomment-67561129
  
    Maybe I'm missing something, but I don't see why it's difficult to store the metadata
in plain text. In fact, isn't it necessary to store it in plain text in case we use a special
compression codec? Otherwise we can't even determine the correct codec to decode the rest
of the file. Can we do something like the following:
    
    Keep doing `readline()` until we the line equals the header end marker. We treat all the
lines read so far as metadata in the form `k=v`, which we can just split on `=`. Then, as
soon as we read the header end marker, we stop and pass the input stream to `ReplayListenerBus#replay`,
wrapping it in a compression stream if necessary.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message