spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From marmbrus <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-4618][SQL] Make foreign DDL commands op...
Date Tue, 16 Dec 2014 22:48:58 GMT
Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3470#discussion_r21939209
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala ---
    @@ -36,7 +36,10 @@ import org.apache.spark.sql.catalyst.expressions.{Expression, Attribute}
      */
     @DeveloperApi
     trait RelationProvider {
    -  /** Returns a new base relation with the given parameters. */
    +  /**
    +   * Returns a new base relation with the given parameters.
    +   * Note: the parameters'keywords are case insensitive.
    --- End diff --
    
    Space after `'` and add the phrase "and this insensitivity is enforced by the `Map` that
is passed to the function."


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message