spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From marmbrus <>
Subject [GitHub] spark pull request: [SPARK-4856] [SQL] NullType instead of StringT...
Date Tue, 16 Dec 2014 21:57:29 GMT
Github user marmbrus commented on a diff in the pull request:
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/json/JsonRDD.scala ---
    @@ -263,6 +263,8 @@ private[sql] object JsonRDD extends Logging {
             val elementType = typeOfArray(array)
             buildKeyPathForInnerStructs(array, elementType) :+ (key, elementType)
    +      // we couldn't tell what the type is if the value is null or empty string
    +      case (key: String, value) if value == "" || value == null => (key, NullType)
:: Nil
    --- End diff --
    The null case makes sense to me, but why `""` as well?  That seems to be unequivocally
a `String`

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message