spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-4461][YARN] pass extra java options to ...
Date Fri, 12 Dec 2014 18:40:12 GMT
Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3409#discussion_r21763663
  
    --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
    @@ -352,12 +352,28 @@ private[spark] trait ClientBase extends Logging {
         if (isLaunchingDriver) {
           sparkConf.getOption("spark.driver.extraJavaOptions")
             .orElse(sys.env.get("SPARK_JAVA_OPTS"))
    +        .map(Utils.splitCommandString).getOrElse(Seq.empty)
             .foreach(opts => javaOpts += opts)
           val libraryPaths = Seq(sys.props.get("spark.driver.extraLibraryPath"),
             sys.props.get("spark.driver.libraryPath")).flatten
           if (libraryPaths.nonEmpty) {
             prefixEnv = Some(Utils.libraryPathEnvPrefix(libraryPaths))
    --- End diff --
    
    I'm not strictly against the warning, but that would print a log for every app whenever
someone tries to configure things by default for all use cases by setting both options in
spark-defaults.conf...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message