spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From akopich <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-2199] [mllib] topic modeling
Date Thu, 11 Dec 2014 12:36:46 GMT
Github user akopich commented on the pull request:

    https://github.com/apache/spark/pull/1269#issuecomment-66613030
  
    @jkbradley 
    
    I moved Dirichlet to mllib/stats and added setters to `TokenEnumerator`.
    
    BTW, why was it decided to use setter instead of constructors? We can set default parameter
values in constructor... I don't contest the decision -- I'm just curious. 
    
    As far as I can see, we've got only two things left -- scalastyle and testing against
another open source project. 
    
    I definitely can test it against [tm project](https://github.com/ispras/tm). 
    
    Is it enough to run both implementation on the same data and obtain nearly the same perplexity
values?   Is it necessary to add a unit-test for this? (It may be a headache, because tm was
not tested against scala 2.10... ). 
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message