spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chenghao-intel <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-4483][SQL]Optimization about reduce mem...
Date Wed, 10 Dec 2014 00:26:39 GMT
Github user chenghao-intel commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3375#discussion_r21575519
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashOuterJoin.scala
---
    @@ -68,62 +68,59 @@ case class HashOuterJoin(
       @transient private[this] lazy val DUMMY_LIST = Seq[Row](null)
       @transient private[this] lazy val EMPTY_LIST = Seq.empty[Row]
     
    +  @transient private[this] lazy val joinedRow = new JoinedRow()
    --- End diff --
    
    Yes, we'd better to keep the `joinedRow` object created once for a single task, the MOVE
I suggested should work for this purpose.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message